SMTP Client does not handle empty RCPT TO

[willpower232]

For whatever reason, one of our SMTP-based clients tried to do RCPT TO:<> and was met with an exception from the following code:

https://github.com/postalhq/postal/blob/2595481b266199d8e29347dea2764f2c10202805/lib/postal/smtp_server/client.rb#L254-L256

The problem is that uname.split will not work as uname isn't defined.

I have tried the following changes to no avail

Stack trace:

I don't know any ruby really so if someone could point me in the right direction, I would appreciate it.

[SilverCard]

Try to put the return keyword before the 550 error strings, maybe without it the code continues executing.

[rbozan]

Same as #1019

What an awful bug by the way :/ even if bugs like this happen, they shouldn't just crash the postal server. Just one person has to send this one line through the smtp server and then you can say bye to receiving any new mails..

[willpower232]

Oh yeah, thanks for the link @rbozan. Fortunately, the process should be kept alive by Procodile but its not perfect.

Thanks for the tip @SilverCard, I'll try that later.

[willpower232]

closing in favour of #1019