fix: proxy browser in build tests (#232)

scripts/check-build.test.js

@@ -9,9 +9,9 @@ let urls = [
   },
   {
     url:
-      'https://www.cnn.com/2018/10/12/us/before-after-aerial-images-mexico-beach-devastation-trnd/index.html',
+      'https://www.cnn.com/2019/01/30/politics/trump-intel-chiefs-foreign-policy-iran-isis-north-korea/index.html',
     title:
-      "Before and after images show there's nothing left in some parts of Mexico Beach",
+      'Trump chastises intel chiefs after they contradict him on Iran and claims of foreign policy success',
   },
 ];
 
@@ -38,16 +38,13 @@ if (
     typeof Mercury === 'undefined' ? require('../dist/mercury') : Mercury;
 
   describe('Is Mercury build working', () => {
-    beforeAll(() => {
-      if (Merc.browser) {
-        const proxyUrl = 'http://localhost:3000/';
-        urls = urls.map(article => ({
-          title: article.title,
-          url: proxyUrl + article.url,
-        }));
-      }
-    });
-
+    if (Merc.browser) {
+      const proxyUrl = 'http://localhost:3000/';
+      urls = urls.map(article => ({
+        title: article.title,
+        url: proxyUrl + article.url,
+      }));
+    }
     urls.map(article =>
       it(`gets this title right ${article.title}`, done => {
         Merc.parse(article.url)
@@ -60,7 +57,7 @@ if (
             assert.equal(true, false);
             done();
           });
-      }, 10000)
+      }, 15000)
     );
   });
 }

scripts/proxy-browser-test.js

@@ -6,8 +6,8 @@ const app = express();
 var server;
 
 const start = () => {
-  app.use('/', (req, res) => {
-    const url = req.url.slice(1);
+  app.use('/:url', (req, res) => {
+    const url = req.originalUrl.slice(1);
 
     const options = {
       url,
@@ -32,9 +32,17 @@ const stop = () => {
 };
 
 start();
-require('child_process').execSync(
+require('child_process').exec(
   'node ./node_modules/karma/bin/karma start ./scripts/karma.conf.js' +
     (process.env.CI ? ' --CI' : ''),
-  { stdio: [0, 1, 2] }
+  { stdio: [0, 1, 2] },
+  (err, stdout) => {
+    if (err) {
+      console.log('stdout', stdout);
+      process.exit(1);
+    } else {
+      console.log('stdout', stdout);
+    }
+    stop();
+  }
 );
-stop();