Skip to content

Commit

Permalink
feat: msnbc parser (#100)
Browse files Browse the repository at this point in the history
* feat: msnbc parser
  • Loading branch information
janetleekim authored and kev5873 committed Feb 6, 2017
1 parent f9ab9eb commit 3cf2d0d
Show file tree
Hide file tree
Showing 4 changed files with 148 additions and 0 deletions.
1 change: 1 addition & 0 deletions fixtures/www.msnbc.com/1482261084088.html

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions src/extractors/custom/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export * from './www.reuters.com';
export * from './mashable.com';
export * from './www.chicagotribune.com';
export * from './www.vox.com';
export * from './www.msnbc.com';
export * from './www.thepoliticalinsider.com';
export * from './www.mentalfloss.com';
export * from './abcnews.go.com';
Expand Down
59 changes: 59 additions & 0 deletions src/extractors/custom/www.msnbc.com/index.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
export const WwwMsnbcComExtractor = {
domain: 'www.msnbc.com',

title: {
selectors: [
'h1',
'h1.is-title-pane',
],
},

author: {
selectors: [
'.author',
],
},

date_published: {
selectors: [
['meta[name="DC.date.issued"]', 'value'],
],
},

dek: {
selectors: [
['meta[name="description"]', 'value'],
],
},

lead_image_url: {
selectors: [
['meta[name="og:image"]', 'value'],
],
},

content: {
selectors: [
'.pane-node-body',
],

// Is there anything in the content you selected that needs transformed
// before it's consumable content? E.g., unusual lazy loaded images
transforms: {
'.pane-node-body': ($node, $) => {
const [selector, attr] = WwwMsnbcComExtractor.lead_image_url.selectors[0];
const src = $(selector).attr(attr);
if (src) {
$node.prepend(`<img src="${src}" />`);
}
},
},

// Is there anything that is in the result that shouldn't be?
// The clean selectors will remove anything that matches from
// the result
clean: [

],
},
};
87 changes: 87 additions & 0 deletions src/extractors/custom/www.msnbc.com/index.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,87 @@
import assert from 'assert';
import fs from 'fs';
import URL from 'url';
import cheerio from 'cheerio';

import Mercury from 'mercury';
import getExtractor from 'extractors/get-extractor';
import { excerptContent } from 'utils/text';

describe('WwwMsnbcComExtractor', () => {
describe('initial test case', () => {
let result;
let url;
beforeAll(() => {
url =
'http://www.msnbc.com/rachel-maddow-show/bizarre-election-ends-bizarre-electoral-college-tally';
const html =
fs.readFileSync('./fixtures/www.msnbc.com/1482261084088.html');
result =
Mercury.parse(url, html, { fallback: false });
});

it('is selected properly', () => {
// This test should be passing by default.
// It sanity checks that the correct parser
// is being selected for URLs from this domain
const extractor = getExtractor(url);
assert.equal(extractor.domain, URL.parse(url).hostname);
});

it('returns the title', async () => {
// To pass this test, fill out the title selector
// in ./src/extractors/custom/www.msnbc.com/index.js.
const { title } = await result;

// Update these values with the expected values from
// the article.
assert.equal(title, 'A bizarre election ends with a bizarre Electoral College tally');
});

it('returns the author', async () => {
// To pass this test, fill out the author selector
// in ./src/extractors/custom/www.msnbc.com/index.js.
const { author } = await result;

// Update these values with the expected values from
// the article.
assert.equal(author, 'Steve Benen');
});

it('returns the date_published', async () => {
// To pass this test, fill out the date_published selector
// in ./src/extractors/custom/www.msnbc.com/index.js.
const { date_published } = await result;

// Update these values with the expected values from
// the article.
assert.equal(date_published, '2016-12-20T13:00:06.000Z');
});

it('returns the lead_image_url', async () => {
// To pass this test, fill out the lead_image_url selector
// in ./src/extractors/custom/www.msnbc.com/index.js.
const { lead_image_url } = await result;

// Update these values with the expected values from
// the article.
assert.equal(lead_image_url, 'http://www.msnbc.com/sites/msnbc/files/styles/ratio--1_91-1--1200x630/public/trump.jpeg-99fbe.jpg?itok=2azRDj-y');
});

it('returns the content', async () => {
// To pass this test, fill out the content selector
// in ./src/extractors/custom/www.msnbc.com/index.js.
// You may also want to make use of the clean and transform
// options.
const { content } = await result;

const $ = cheerio.load(content || '');

const first13 = excerptContent($('*').first().text(), 13);

// Update these values with the expected values from
// the article.
assert.equal(first13, 'On Election Day, Donald Trump earned 306 electoral votes to Hillary Clinton’s 232,');
});
});
});

0 comments on commit 3cf2d0d

Please sign in to comment.