Ensure error changes are added to changes block

[snewcomer]

I haven't investigated the implications of this change; however, this is what it would look like. Note - there are still tests that execute and do not apply those changes if invalid.

I'm not sure if there is historical reasons for this or if simply was a design decision.

This also might require more information in the README.

Ref #297
#297 (comment)

[snewcomer]

@bgentry Mind trying out this PR and lmk if anything breaks for you (of course if you have time :) )?

[snewcomer]

@XaserAcheron Somewhat modifying what you did (the tests), but would love to hear your opinion on this PR. It essentially still adds changes to the changeset even if it is not valid.

[XaserAcheron]

This breaks rollbackInvalid, but it ought to be a simple fix. You'll want to revert the definition of the test and add a couple of lines here-ish to also remove the invalid items from the CHANGES hash. Should do the trick.

[snewcomer]

@XaserAcheron ooo great call! Hadn't thought of that. Since the errors are potential, we need to see if they actually exist and then delete from the changes hash if present in the errors hash. 👍

[XaserAcheron]

Just saw the commit -- looks good now! Or at least that little tiny feature I contributed looks good now, for what it's worth. :P