Update to 3.2 #306
Update to 3.2 #306
Conversation
|
@Dhaulagiri Mind doing a quick review when you get a chance? Need this for other PR's in the pipeline. 🙏 |
.travis.yml
Outdated
|
|
||
| script: | ||
| - yarn flow | ||
| - npm run lint:js | ||
| - yarn lint:js |
There was a problem hiding this comment.
Do we still need to run flow here?
package.json
Outdated
| "flow-bin": "^0.61.0", | ||
| "flow-typed": "^2.2.3", | ||
| "loader.js": "^4.2.3" | ||
| }, | ||
| "engines": { | ||
| "node": "^4.5 || 6.* || >= 7.*" | ||
| "node": "6.* || 8.* || >= 10.*" |
There was a problem hiding this comment.
In theory dropping node 4 support is a breaking change so we should probably leave that
There was a problem hiding this comment.
Since we are on a beta branch, do you think its ok to leave out? I think node 4.* only supports up to 3.1 as well. Lmk what you think.
There was a problem hiding this comment.
🤷♂️ I don't have a strong feeling about it since my experience is that I haven't used node 4 for a very long time, but I know I've seen other addons be cautious about this.
There was a problem hiding this comment.
@Dhaulagiri Yeah I think you are right. I put the ^4.5 back 👍
No description provided.