Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not clear changes after pushErrors #311

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Conversation

snewcomer
Copy link
Collaborator

I'm not totally sure why CHANGES are cleared when manually pushing an error clears the changes, resulting in dirty state to reset, but this PR removes that

close #177

@snewcomer snewcomer merged commit 7dbd9b9 into master Aug 28, 2018
@snewcomer snewcomer deleted the sn/no-push-error-clear branch August 28, 2018 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually adding errors to a property marks it as no longer dirty
1 participant