-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.5.2 - link failure when multilink is disabled #541
Comments
Weird, I can't reproduce that here. If you do |
To (hopefully) let you get to the bottom of the problem quicker, I have attached the artifacts from the build directory where the fail happens - source tree in 2.5.2/ppp-2.5.2, build tree in 2.5.2/build, build logs in 2.5.2/temp/log.* We're building with gcc 14.2. |
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 0b2f41d4763ef4035b2718f67d25584d2f9e59fc) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 0b2f41d4763ef4035b2718f67d25584d2f9e59fc) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: a7a611f264956522858059960657914681849403) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: a7a611f264956522858059960657914681849403) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 5d62401d3273e2f4d95272bce6a5ac1e41a99cc2) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: 890badc6e450051f6e185ff87f54222617c2419c) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: acf3db7a52df28bba833236e464b73592634cd05) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: acf3db7a52df28bba833236e464b73592634cd05) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: e6ea3ade8f3977ec93c68229d2660bbc335a80a6) Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]> Signed-off-by: Richard Purdie <[email protected]>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: e6ea3ade8f3977ec93c68229d2660bbc335a80a6) Signed-off-by: Alexander Kanavin <alexlinutronix.de> Signed-off-by: Richard Purdie <richard.purdielinuxfoundation.org>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 (From OE-Core rev: e6ea3ade8f3977ec93c68229d2660bbc335a80a6) Signed-off-by: Alexander Kanavin <alexlinutronix.de> Signed-off-by: Richard Purdie <richard.purdielinuxfoundation.org>
License-Update: BSD items clarified to be 2-clause: ppp-project/ppp@d4ec06e passprompt plugin removed upstream. Add an enable a multilink option, as the build breaks without it at the linking step (upstream presumably didn't test that it works): ppp-project/ppp#541 Signed-off-by: Alexander Kanavin <[email protected]>
@paulusmack: Have you seen the latest @kanavin comment? |
@jkroonza: What do you think about this ticket? |
Looks like link failure issue. Will take a peek, I recall having had run-time issues with multilink before on openl2tpd but this is different. |
I can't reproduce either. This does look like a potential cross-compile issue though (--build=x86_64-linux != --{host,target}=x86_64-pokey-linux). Looks like it's being compiled into a sysroot, which means that possibly headers are installed and available but not the libraries? This means it's all x86_64, but technically is still a cross-compile. @kanavin you make it sound like merely changing --disable-multilink to --enable-multilink makes the build work? At least mp_master (from all of the symbols) does seem to relate specifically to multilink, there are two definitions in multilink.h. The problem seems to be that some sources were built with PPP_WITH_MULTILINK set (which would cause muiltilink.h to reference the definitions in multilink.c), and this was then later changed, and without cleaning the tree a rebuild then follows that doesn't attempt to link in multilink.c. Similar consideration for tbd (--with-tdb, but that's implicitly enabled by --with-multilink in this case I believe). @kanavin can you please make sure you build in a clean build location? I'd say that the pppol2tp might relate but that's not what you're busy linking here when the failure happens (it does #include <pppd/????> for pppd includes though, which I suspect should be #include "????" rather). |
Specifically, this happens:
The text was updated successfully, but these errors were encountered: