Add replacedefaultroute option #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 30, 2020
Closed
sthibaul
force-pushed
the
cifdefroute
branch
from
fdff6e7 to
116b195
Compare
paulusmack
requested changes
Dec 31, 2020
sthibaul
force-pushed
the
cifdefroute
branch
2 times, most recently
from
0b79bfa to
be0c353
Compare
Adds an option to pppd to control whether to replace existing default routes when using the 'defaultroute' option. If defaultroute and replacedefaultroute are both set, pppd replaces an existing default route with the new default route. The old default route is restored when the connection is taken down. Signed-off-by: Samuel Thibault <[email protected]>
sthibaul
added a commit
to sthibaul/ppp
that referenced
this pull request
Jan 10, 2024
For instance, when using a ppp link as backup link, one would want to add a default route on the ppp link, in *addition* to the existing default route. d0ccb87 ("pppd: Add replacedefaultroute option (ppp-project#200)") however broke this case: sifdefaultroute was not passing the metric to defaultroute_exists any more. This commit restores this case. Fixes ppp-project#357
sthibaul
added a commit
to sthibaul/ppp
that referenced
this pull request
Jan 10, 2024
For instance, when using a ppp link as backup link, one would want to add a default route on the ppp link, in *addition* to the existing default route. d0ccb87 ("pppd: Add replacedefaultroute option (ppp-project#200)") however broke this case: sifdefaultroute was not passing the metric to defaultroute_exists any more. This commit restores this case. Fixes ppp-project#357 Signed-off-by: Samuel Thibault <[email protected]>
paulusmack
pushed a commit
that referenced
this pull request
Feb 13, 2024
For instance, when using a ppp link as backup link, one would want to add a default route on the ppp link, in *addition* to the existing default route. d0ccb87 ("pppd: Add replacedefaultroute option (#200)") however broke this case: sifdefaultroute was not passing the metric to defaultroute_exists any more. This commit restores this case. Fixes #357 Signed-off-by: Samuel Thibault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to pppd to control whether to replace existing default routes
when using the 'defaultroute' option.
If defaultroute and replacedefaultroute are both set, pppd replaces an existing
default route with the new default route. The old default route is restored when
the connection is taken down.
Signed-off-by: Samuel Thibault [email protected]