diff --git a/.changeset/loud-monkeys-compete.md b/.changeset/loud-monkeys-compete.md new file mode 100644 index 000000000..e7e006ee6 --- /dev/null +++ b/.changeset/loud-monkeys-compete.md @@ -0,0 +1,5 @@ +--- +'preact-cli': patch +--- + +Replacing mkdirp with native mkdir recursive diff --git a/packages/cli/lib/commands/create.js b/packages/cli/lib/commands/create.js index 3079723f4..0bee9f75e 100644 --- a/packages/cli/lib/commands/create.js +++ b/packages/cli/lib/commands/create.js @@ -3,7 +3,6 @@ const { promisify } = require('util'); const fetch = require('isomorphic-unfetch'); const glob = promisify(require('glob').glob); const gittar = require('gittar'); -const mkdirp = require('mkdirp'); const fs = require('../fs'); const os = require('os'); const { green } = require('kleur'); @@ -271,7 +270,7 @@ async function command(repo, dest, argv) { } if (!fs.existsSync(resolve(cwd, dest, 'src'))) { - mkdirp.sync(resolve(cwd, dest, 'src')); + fs.mkdirSync(resolve(cwd, dest, 'src'), { recursive: true }); } // Attempt to fetch the `template` diff --git a/packages/cli/lib/fs.js b/packages/cli/lib/fs.js index d2657fabe..8ec821efc 100644 --- a/packages/cli/lib/fs.js +++ b/packages/cli/lib/fs.js @@ -1,5 +1,6 @@ const { mkdir, + mkdirSync, readFile, writeFile, copyFile, @@ -11,6 +12,7 @@ const { promisify } = require('util'); module.exports = { mkdir: promisify(mkdir), + mkdirSync, copyFile: promisify(copyFile), readFile: promisify(readFile), writeFile: promisify(writeFile), diff --git a/packages/cli/package.json b/packages/cli/package.json index 083f97c63..7de1f5bfd 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -47,7 +47,6 @@ "devDependencies": { "html-looks-like": "^1.0.2", "jest": "^26.0.1", - "mkdirp": "^1.0.3", "ncp": "^2.0.0", "node-sass": "^4.12.0", "p-retry": "^4.1.0", diff --git a/packages/cli/tests/lib/cli.js b/packages/cli/tests/lib/cli.js index 2fe9a96ac..190597bb9 100644 --- a/packages/cli/tests/lib/cli.js +++ b/packages/cli/tests/lib/cli.js @@ -1,8 +1,7 @@ const { join } = require('path'); -const { existsSync, unlinkSync, symlinkSync } = require('fs'); +const { existsSync, mkdirSync, unlinkSync, symlinkSync } = require('fs'); const cmd = require('../../lib/commands'); const { tmpDir } = require('./output'); -const mkdirp = require('mkdirp'); const shell = require('shelljs'); const root = join(__dirname, '../../../..'); @@ -37,7 +36,7 @@ exports.create = async function (template, name) { exports.build = function (cwd, options, installNodeModules = false) { if (!installNodeModules) { - mkdirp.sync(join(cwd, 'node_modules')); // ensure exists, avoid exit() + mkdirSync(join(cwd, 'node_modules'), { recursive: true }); // ensure exists, avoid exit() linkPackage('preact', root, cwd); linkPackage('preact-render-to-string', root, cwd); } else {