Skip to content

Commit

Permalink
update options hooks tests to reflect correct calling order
Browse files Browse the repository at this point in the history
  • Loading branch information
developit committed Aug 19, 2022
1 parent 4727e9f commit a3921d7
Showing 1 changed file with 24 additions and 16 deletions.
40 changes: 24 additions & 16 deletions test/render.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1154,30 +1154,38 @@ describe('render', () => {
if (oldCommit) oldCommit(...args);
};

function Component1({ children }) {
return children;
}
const outer = <Outer />;
const inner = <Inner />;
const div = <div />;

function Component2() {
return <div />;
function Outer() {
return inner;
}

const vnode2 = <Component2>1</Component2>;
const vnode1 = <Component1>{vnode2}</Component1>;
function Inner() {
return div;
}

render(vnode1);
render(outer);

expect(calls).to.deep.equal([
['_diff', [vnode1]],
['_render', [vnode1]],
['diffed', [vnode1]],
['_diff', [vnode2]],
['_render', [vnode2]],
['diffed', [vnode2]],
['_commit', [vnode1, []]]
['_diff', [outer]], // before diff
['_render', [outer]], // render attempt

['_diff', [inner]], // before diff
['_render', [inner]], // render attempt

// innermost <div>
['_diff', [div]], // before diff
['diffed', [div]], // after diff

['diffed', [inner]], // after diff
['diffed', [outer]], // after diff

['_commit', [outer, []]] // commit root
]);

expect(calls.length).to.equal(7);
expect(calls.length).to.equal(9);

options.__b = oldDiff;
options.__r = oldRender;
Expand Down

0 comments on commit a3921d7

Please sign in to comment.