fix: onBeforeInput event type

preactjs · Dec 7, 2023 · 0c7fd52 · 0c7fd52
1 parent 5f816b4
commit 0c7fd52
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/jsx.d.ts b/src/jsx.d.ts
@@ -1575,8 +1575,8 @@ export namespace JSXInternal {
 		onChangeCapture?: GenericEventHandler<Target> | undefined;
 		onInput?: InputEventHandler<Target> | undefined;
 		onInputCapture?: InputEventHandler<Target> | undefined;
-		onBeforeInput?: GenericEventHandler<Target> | undefined;
-		onBeforeInputCapture?: GenericEventHandler<Target> | undefined;
+		onBeforeInput?: InputEventHandler<Target> | undefined;
+		onBeforeInputCapture?: InputEventHandler<Target> | undefined;
 		onSearch?: GenericEventHandler<Target> | undefined;
 		onSearchCapture?: GenericEventHandler<Target> | undefined;
 		onSubmit?: SubmitEventHandler<Target> | undefined;

diff --git a/test/ts/preact.tsx b/test/ts/preact.tsx
@@ -368,7 +368,12 @@ const onInput = (e: h.JSX.TargetedInputEvent<HTMLInputElement>) => {};
 createElement('input', { onInput: onInput });
 h('input', { onInput: onInput });
 
-// Should accept onSubmit
+// Should accept onBeforeInput
+const onBeforeInput = (e: h.JSX.TargetedInputEvent<HTMLInputElement>) => {};
+<input onBeforeInput={e => e.currentTarget.value} />;
+createElement('input', { onBeforeInput: onBeforeInput });
+h('input', { onBeforeInput: onBeforeInput });
+
 const onSubmit = (e: h.JSX.TargetedSubmitEvent<HTMLFormElement>) => {};
 <form onSubmit={e => e.currentTarget.elements} />;
 createElement('form', { onSubmit: onSubmit });