10.0.0-alpha.1 - __hooks of undefined with render-to-string

[vaneenige]

There's an odd bug when using hooks together with render-to-string.

What I had was a simple component with the useState hook. Rendered on the client this was fine, on the server it resulted in: Uncaught TypeError: Cannot read property '__H' of undefined.

At first I thought this had something to do with render-to-string because the error also occurred when I replaced preact's render function on the client with render-to-string. After some more investigation this wasn't actually a bug in that library but rather in preact/hooks, let me explain:

The __H in the error stands for __hooks that can't be read because currentComponent is undefined. This is defined when you use preact's render function. In this codesandbox you can see that at first render-to-string throws the error, after that the same component renders fine (normal render function), then render-to-string works!

[marvinhagemeister]

Had a look into this and the issue is that we never set vnode._component anywhere in render-to-string. This will lead to currentComponent always being null in preact/hooks and finally to an exception when we try to access currentComponent.__hooks a few lines later.

[developit]

Awesome catch, was looking at your PR this morning.

[marvinhagemeister]

Version 5.0.1 for preact-render-to-string went live with a fix for this issue 🎉

[marvinhagemeister]

Looks like the issue is not completely fixed. @vaneenige send this test case on slack https://codesandbox.io/s/k9mk2rloqr

[sync]

yes experiencing same issue with version 5.0.1

[vaneenige]

Fixed in preactjs/preact-render-to-string#77 👍

[didymu5]

Was this ever resolved? I still get the undefined error, with a built package.
In development the hooks work fine. However, after I build and serve the built .js package, I get the following error.

hooks.module.js:1 Uncaught TypeError: Cannot read property '__H' of undefined
    at r (hooks.module.js:1)
    at i (hooks.module.js:1)
    at o (hooks.module.js:1)
    at S.p [as constructor] (index.js:6)
    at S.x [as render] (preact.min.js:1)
    at j (preact.min.js:1)
    at C (preact.min.js:1)
    at N (preact.min.js:1)
    at _ (preact.min.js:1)
    at v (preact.min.js:1)

"devDependencies": {
    "eslint": "^4.5.0",
    "identity-obj-proxy": "^3.0.0",
    "if-env": "^1.0.0",
    "jest": "^21.2.1",
    "microbundle": "^0.6.0",
    "node-sass": "^4.5.3",
    "preact-cli": "^2.0.2",
    "preact-render-to-string": "^3.7.0",
    "preact-widget-scripts": "^0.6.0",
    "sass-loader": "^6.0.6"
  },
  "dependencies": {
    "preact": "^10.0.0-rc.1",
    "preact-compat": "^3.17.0",
    "preact-habitat": "^3.1.0",
    "preact-render-to-string": "^4.1.0",
    "preact-router": "^2.5.7"
  },

[JoviDeCroock]

@didymu5 yes by using the new version of render-to-string

[vaneenige]

I see you're using Preact X, to get this to work you will need to install the next version of preact-render-to-string, which is currently at 5.0.6, the older version will not work.

[didymu5]

Thanks for responding. hmm... here's what I have now. Same result.

"devDependencies": {
    "eslint": "^4.5.0",
    "identity-obj-proxy": "^3.0.0",
    "if-env": "^1.0.0",
    "jest": "^21.2.1",
    "microbundle": "^0.6.0",
    "node-sass": "^4.5.3",
    "preact-cli": "^2.0.2",
    "preact-widget-scripts": "^0.6.0",
    "sass-loader": "^6.0.6"
  },
  "dependencies": {
    "preact": "^10.0.0-rc.1",
    "preact-compat": "^3.17.0",
    "preact-habitat": "^3.1.0",
    "preact-render-to-string": "^5.0.6",
    "preact-router": "^2.5.7"
  },

[didymu5]

I should also add that I'm not really using render-to-string. Instead I used the widget template from the preact-cli

[ForsakenHarmony]

sorry, the widget template is a bit broken because preact-habitat is not updated

[VladSez]

Hi, @marvinhagemeister the issue is still present

Bootstrapped with preact-cli

[VladSez]

By the way it worked using this

which i have found here https://github.com/preactjs/cli-demo

[mcclure]

Leaving this for the next person who makes the mistake I made:

If you are new to Preact and you found this bug by searching "Cannot read property '__H' of undefined" on Google: That error message can also happen if you call useState and you are not actually in a component function. I recommend enabling "preact/debug": https://preactjs.com/guide/v10/debugging/

[developit]

Thanks for pointing folks in the right direction @mcclure! I wonder if it would be worth creating a page on preactjs.com that lists out common error messages with fixes for each? That way anyone googling gets a nice resource with a clear answer.

[victor-ca]

I've landed here because of

Uncaught (in promise) TypeError: Cannot read property '__hooks' of undefined
// fired from 
var hooks = currentComponent.__hooks 

the cause was vs-code auto-import looking like this

import { useState, useCallback } from 'preact/hooks/src';
// instead of this
import { useState, useCallback } from 'preact/hooks'; 

[barelyhuman]

Didn't want to open a new issue for this,

barelyhuman/mage#7

has a similar compilation issue, due to the same reason.

_component doesn't get set when using a function that generates the Component