Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audio tag not support volume attribute in typescripts #1934

Closed
CarmeloXue opened this issue Sep 18, 2019 · 1 comment · Fixed by #1938
Closed

audio tag not support volume attribute in typescripts #1934

CarmeloXue opened this issue Sep 18, 2019 · 1 comment · Fixed by #1938
Labels
beginner-friendly types

Comments

@CarmeloXue
Copy link

I use 10.0.0-rc.1, and I want to use <audio {...someProps} volume={0.1}>.
But in ts, I got an error :
Property 'volume' does not exist on type 'HTMLAttributes'.
Then I found in index.d.ts file where HTMLAttributes just don't include this attribute.
Is there any chance to add this?
@jessicabyrne
Copy link
Contributor

I'll tackle this beginner-friendly one.

@jessicabyrne jessicabyrne mentioned this issue Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding volume to HTML Attributes jessicabyrne/preact
3 participants
@marvinhagemeister @jessicabyrne @CarmeloXue