-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework children diffing to run in multiple phases #4162
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
61fb579
Pass render.tests.js with new diffing algo
andrewiggins d639ae0
Prepare code for bringing back skew
andrewiggins dc37be1
Fix placeholder tests
andrewiggins 0774f26
Fix keyed tests by implementing skewed diff
andrewiggins 477ca83
Fix Fragment tests
andrewiggins b23dd6f
Enable & fix all tests but compat
andrewiggins 79f0c82
Fix linting error
andrewiggins 09db106
Add mangle config so minified tests pass
andrewiggins 4095c1a
Fix suspense tests
andrewiggins e7847df
Fix suspense hydration tests
andrewiggins 6e9ba3f
Fix suspense-list tests (investigate further)
andrewiggins eb3dddc
Reuse iterator variable in second loop
andrewiggins 08e4a2b
Remove _prevVNode field and reuse _index to temporarily hold matching…
andrewiggins c60ff18
Some golfing
andrewiggins 184d578
Replace _matched & _insert with _flags
andrewiggins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,14 @@ | ||
/** Indicates that this node needs to be inserted while patching children */ | ||
export const INSERT_VNODE = 1 << 16; | ||
export const MATCHED = 1 << 17; | ||
|
||
/** Reset all mode flags */ | ||
export const RESET_MODE = ~(INSERT_VNODE | MATCHED); | ||
|
||
export const EMPTY_OBJ = {}; | ||
export const EMPTY_VNODE = /** @type {import('./internal').VNode} */ ( | ||
EMPTY_OBJ | ||
); | ||
export const EMPTY_ARR = []; | ||
export const IS_NON_DIMENSIONAL = | ||
/acit|ex(?:s|g|n|p|$)|rph|grid|ows|mnc|ntw|ine[ch]|zoo|^ord|itera/i; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably unnecessary - will undo to reduce size later. Did this temporarily to make TypeScript happy in my editor.