Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmark debug action #4187

Merged
merged 4 commits into from
Nov 1, 2023
Merged

Fix benchmark debug action #4187

merged 4 commits into from
Nov 1, 2023

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Oct 31, 2023

Couple issues found in the "Benchmark Debug" & related changes to "CI" workflow:

  • CI ref input should default to empty string so by default it checkouts whatever the default commit of the event that triggered it (e.g. merge commit for pull_request event, pushed commit for push event)
  • Add npm run analyze command for benchmarks that include logs to analyze
  • There is a bug in GitHub workflow parser that doesn't properly handle number-like inputs being passed as an input to a called workflow. Comment out timeout input for now
  • Fix ordering of tarballing and clearing directory.
  • Add option to specify benchmark to analyze in analyze script
  • Make analyze script resilient to malformed logs

@coveralls
Copy link

coveralls commented Oct 31, 2023

Coverage Status

coverage: 99.43%. remained the same when pulling 0fc963f on fix-benchmark-debug into 30873a3 on main.

@andrewiggins andrewiggins marked this pull request as ready for review November 1, 2023 00:34
@andrewiggins
Copy link
Member Author

@andrewiggins andrewiggins merged commit f54942a into main Nov 1, 2023
@andrewiggins andrewiggins deleted the fix-benchmark-debug branch November 1, 2023 15:37
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants