Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for HTML translate attribute #4465

Closed
wants to merge 1 commit into from
Closed

Fix typings for HTML translate attribute #4465

wants to merge 1 commit into from

Conversation

teodragovic
Copy link
Contributor

Fixes #4464

Wasn't sure if boolean is better removed or left in (I think "empty string" part from the specs would be same as translate={true})?

@coveralls
Copy link

Coverage Status

coverage: 99.486%. remained the same
when pulling 3d4e7b0 on teodragovic:patch-1
into 9351588 on preactjs:main.

@rschristian
Copy link
Member

rschristian commented Jul 31, 2024 •
edited
Loading

Unfortunately, I don't think this is correct, see #3800

We set the translate property, not the attribute, which is a boolean rather than a 'yes' | 'no'

@teodragovic teodragovic closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong typing for HTML translate property
3 participants
@teodragovic @coveralls @rschristian