-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move donation message to scripts #804
Conversation
this fixes issue where installation would fail in environments where `npm` is not available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks a bunch for the PR. Any idea if this works under Windows? If not I can check.
Please do check if it works under Windows |
Changes Unknown when pulling d8b0199 on andrejsm:master into ** on developit:master**. |
Seems like it doesn't work under Win. |
Thanks for checking. I'll then rewrite it to |
Moved from Shell script to Nodejs script. Works on Windows as well. |
Awesome - tested that out locally too and it works well. Only thing I'd like to see (and I don't mind doing it myself post-merge) is instead of using |
Moved to |
Works great! |
This fixes the issue where installation would fail in environments where
npm
is not available.Fixes #803