Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId module: define getEid method & SharedId Id submodule: support for recently added eid object fields #12641

Closed
patmmccann opened this issue Jan 10, 2025 · 1 comment · Fixed by #12664

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Jan 10, 2025

We need to allow the publisher to define inserter via config for the sharedid module

See https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#objecteid

We should incorporate the comment below to allow id submodules to define a getEid method into the requirements and label the pr as having that feature

<!--StartFragment-->
Attribute | Type | Description
-- | -- | --
inserter | string | The canonical domain name of the entity (publisher, publisher monetization company, SSP, Exchange, Header Wrapper, etc.) that caused the ID array element to be added. This may be the operational domain of the system, if that is different from the parent corporate domain, to facilitate WHOIS and reverse IP lookups to establish clear ownership of the delegate system.This should be the same value as used to identify sellers in an ads.txt file if one exists.For ad tech intermediaries, this would be the domain as used in ads.txt. For publishers, this would match the domain in the site or app object.
source | string | Canonical domain of the ID.
matcher | string | Technology providing the match method as defined in mm.In some cases, this may be the same value as inserter.When blank, it is assumed that the matcher is equal to the sourceMay be omitted when mm=0, 1, or 2.
mm | int | Match method used by the matcher. Refer to List: ID Match Methods in AdCOM 1.0

<!--EndFragment-->
</body>
</html>Attribute        	Type                    	Description
inserter	string	The canonical domain name of the entity (publisher, publisher monetization company, SSP, Exchange, Header Wrapper, etc.) that caused the ID array element to be added. This may be the operational domain of the system, if that is different from the parent corporate domain, to facilitate WHOIS and reverse IP lookups to establish clear ownership of the delegate system.

This should be the same value as used to identify sellers in an ads.txt file if one exists.

For ad tech intermediaries, this would be the domain as used in ads.txt. For publishers, this would match the domain in the site or app object.
source	string	Canonical domain of the ID.
matcher	string	Technology providing the match method as defined in mm.

In some cases, this may be the same value as inserter.

When blank, it is assumed that the matcher is equal to the source

May be omitted when mm=0, 1, or 2.
mm	int	Match method used by the matcher. Refer to [List: ID Match Methods](https://github.com/InteractiveAdvertisingBureau/AdCOM/blob/main/AdCOM%20v1.0%20FINAL.md#list-id-match-methods-) in AdCOM 1.0

@dgirardi
Copy link
Collaborator

Given an ID module's EID defition def, and an ID value id, the EID is currently defined as:

{
   source: def.getSource?.(id) ?? def.source,
   uid: [{
       id: def.getValue?.(id) ?? id,
       atype: def.atype,
       ext: def.getUidExt?.(id)
   }],
   ext: def.getEidExt?.(id)
}

Proposal

Instead of the above, ID modules can provide a function taking the ID value (such as def(id)) and returning the full EID.

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Jan 13, 2025
@patmmccann patmmccann changed the title SharedId Id submodule: support for recently added eid object fields UerId module: define getEid method & SharedId Id submodule: support for recently added eid object fields Jan 13, 2025
@patmmccann patmmccann changed the title UerId module: define getEid method & SharedId Id submodule: support for recently added eid object fields UserId module: define getEid method & SharedId Id submodule: support for recently added eid object fields Jan 13, 2025
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants