Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTopWindowLocation, getTopFrameReferrer, getAncestorOrigins will be deprecated soon #3072

Closed
jaiminpanchal27 opened this issue Sep 11, 2018 · 5 comments
Closed

getTopWindowLocation, getTopFrameReferrer, getAncestorOrigins will be deprecated soon #3072

jaiminpanchal27 opened this issue Sep 11, 2018 · 5 comments
Labels
Adapter API Change Bidder Adapter API Change API Impact intent to implement pinned won't be closed by stalebot

Comments

@jaiminpanchal27
Copy link
Collaborator

Type of issue

Feature

Description

We have added referer detection module #3067 here.
We will be deprecating getTopWindowLocation, getTopFrameReferrer, getAncestorOrigins methods from utils.js
@jsnellbaker jsnellbaker mentioned this issue Sep 13, 2018
Closed
9 tasks
@brittanyzellman brittanyzellman mentioned this issue Sep 28, 2018
Merged
9 tasks
@pm-harshad-mane
Copy link
Contributor

Hello @jaiminpanchal27 ,
utils.getTopWindowUrl() refers to utils. getTopWindowLocation, are we planning to deprecate utils.getTopWindowUrl and utils.getTopWindowReferrer as well?

@pm-harshad-mane
Copy link
Contributor

Hello @jsnellbaker ,
can you please answer above query?

@jaiminpanchal27
Copy link
Collaborator Author

@pm-harshad-mane Yes we will deprecate those as well. In this sprint i am working on adding location object and canonical url to refererInfo.
We will add everything to bidRequest.refererInfo and ask all adapter to update.

You can find info here http://prebid.org/dev-docs/bidder-adaptor.html#referrers

@jaiminpanchal27 jaiminpanchal27 mentioned this issue Feb 14, 2019
Closed
@pm-harshad-mane
Copy link
Contributor

Thank you @jaiminpanchal27

@mkendall07 mkendall07 added Adapter API Change Bidder Adapter API Change and removed good first issue labels Oct 7, 2019
@Fawke Fawke mentioned this issue Nov 22, 2019
Merged
@jaiminpanchal27
Copy link
Collaborator Author

3.0 is released. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Adapter API Change Bidder Adapter API Change API Impact intent to implement pinned won't be closed by stalebot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mkendall07 @jaiminpanchal27 @pm-harshad-mane @jsnellbaker