Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When bidRequests is empty, an error occured: numRequiredCalls must be a positive number. Got 0 #3137

Closed
drdmitry opened this issue Sep 27, 2018 · 1 comment
Assignees
Labels

Comments

@drdmitry
Copy link
Contributor

drdmitry commented Sep 27, 2018

Type of issue

Bug

Description

When no sizesSupported are available requestBids throws an exception

Steps to reproduce

  1. sizeConfig = [{
    "mediaQuery": "(min-width: 801px)",
    "sizesSupported": [
    [800, 250],
    [970, 250]
    ],
    "labels": ["label-ad"]
    }, {
    "mediaQuery": "(min-width: 0px) and (max-width: 800px)",
    "sizesSupported": [],
    "labels": ["label-ad"]
    }]
  2. running on a viewport 480px width
  3. when bids are requested, no sizesSupported will be selected, and bidRequests will be empty
  4. but requestBids are starting auction which returns an error
    utils.js:843 Uncaught Error: numRequiredCalls must be a positive number. Got 0
    at delayExecution (utils.js:843)
    at auctionCallbacks (auction.js:299)
    at Object.run (auction.js:193)
    at runIfOriginHasCapacity (auction.js:255)
    at Object.callBids (auction.js:224)
    at Object. (prebid.js:387)
    at Object.hookedFn [as requestBids] (hook.js:75)
    at prebidAdapter.ts:161
    at Function. (targetingFetcher.ts:68)
    at Function. (utils.ts:8)

Test page

Expected results

No error

Actual results

Exception

Platform details

1.24.1

Other information

@snapwich
Copy link
Collaborator

Should be fixed in 1.26 release. Let me know if that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants