Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases in S2SConfig and SyncEndpoint issue #3628

Closed
adriafolchmrf opened this issue Mar 13, 2019 · 2 comments · Fixed by #4265
Closed

Aliases in S2SConfig and SyncEndpoint issue #3628

adriafolchmrf opened this issue Mar 13, 2019 · 2 comments · Fixed by #4265
Labels

Comments

@adriafolchmrf
Copy link

Type of issue

Bug

Description

When specifying aliases in prebid as suggested in the documentation (http://prebid.org/dev-docs/get-started-with-prebid-server.html) we are seeing that in the payload to the syncEndpoint we are not using the proper bidder name but the alias instead, therefore failing due to not finding the bidder in the server.

Steps to reproduce

Adding any alias in the bidders inside the s2sConfig will send them directly to the syncEndpoint without checking for the proper bidder name.

Expected results

Only sending actual bidders to the syncEndpoint

Actual results

Everything set in the s2sConfig.bidders is sent to syncEndpoint

Platform details

Prebid 1.23

@jaiminpanchal27
Copy link
Collaborator

@adriafolchmrf Thanks for reporting this.
When publisher is using alias s2sConfig.bidders list, PBS adapter should find the actual bidderCode and use that to send to userSyncEnpoint.

@adriafolchmrf
Copy link
Author

Just added a PR #3640 to discuss the approach to solve this bug.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants