Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colossus adapter question #4164

Closed
HuddledMasses opened this issue Sep 5, 2019 · 3 comments
Closed

Colossus adapter question #4164

HuddledMasses opened this issue Sep 5, 2019 · 3 comments
Assignees
@jsnellbaker
Labels
docs

Comments

@HuddledMasses
Copy link
Contributor

Colossus adapter is not listed across bidders with native and video demand

Description

As Colossus adapter supports both video and native, should it be listed here as well?
http://prebid.org/dev-docs/bidders.html#bidders-with-video-and-native-demand
or it is not necessary? our initial pull request was located here: #2281

Steps to reproduce

Test page

Expected results

Actual results

Platform details

Other information
@jsnellbaker
Copy link
Collaborator

Just to clarify on this issue, I left a comment on the original PR with some notes on how to have the bidder appear on that table.
#2281 (comment)

If you have any questions on the process, please let me know and I'll be happy to help.

@jsnellbaker jsnellbaker self-assigned this Sep 9, 2019
@HuddledMasses
Copy link
Contributor Author

Thanks @jsnellbaker
we have updated PR: prebid/prebid.github.io#1484
Will you be able to take the look?

Thanks!

@bretg
Copy link
Collaborator

bretg commented Sep 16, 2019

Docs PR merged and confirmed that Colossus is on the list now.

@bretg bretg closed this as completed Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnellbaker jsnellbaker

Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bretg @HuddledMasses @jsnellbaker