Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneVideo adapter raises TypeError in 3.4.0 #4787

Closed
josephtyler opened this issue Jan 28, 2020 · 1 comment · Fixed by #4788
Closed

oneVideo adapter raises TypeError in 3.4.0 #4787

josephtyler opened this issue Jan 28, 2020 · 1 comment · Fixed by #4788
Labels

Comments

@josephtyler
Copy link
Contributor

Type of issue

This appears to be a bug.

Description

When loading the oneVideo module in isolation, a TypeError is thrown every time. When excluding the module, no TypeError.

Steps to reproduce

  • Build with oneVideoBidAdapter
  • Load page, view console
  • I'm not yet sure when we would expect consentData to be undefined, but other modules seem to handle it

Test page

Expected results

Actual results

Platform details

Prebid 3.4.0

Other information

I'll open a PR to fix.

@stale
Copy link

stale bot commented Feb 11, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant