Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge quantumdex and valueimpression adapters #5370

Closed
bretg opened this issue Jun 15, 2020 · 2 comments
Closed

Merge quantumdex and valueimpression adapters #5370

bretg opened this issue Jun 15, 2020 · 2 comments

Comments

@bretg
Copy link
Collaborator

bretg commented Jun 15, 2020

Description

As found in #5356 The valueimpressionBidAdapter is completely identical to quantumdexBidAdapter except, of course, bidder code.

@thuyhq has expressed a willingness to merge these adapters at some point, though they're not able to do this at the moment as it will affect their business.

This issue tracks the open item.

@robertrmartinez
Copy link
Collaborator

Thank you @thuyhq for taking this!

#5405

@stale
Copy link

stale bot commented Jul 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 6, 2020
@stale stale bot closed this as completed Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants