-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention for Page Position #5578
Comments
@bretg Approved, let's move forward with next steps. |
@bretg do we need to reopen this for the adapter changes? |
@bretg should the rubicon adapter copy p_pos to tg_i.pos if it exists? We're being asked to double set. |
Here is an attempt at a list of adapters that need modification: Prebid.js/modules/conversantBidAdapter.js Line 104 in d4ad23f
Gamoshi md file and Prebid.js/modules/gamoshiBidAdapter.js Line 70 in d4ad23f
Kobler Prebid.js/modules/koblerBidAdapter.js Line 192 in 180ddaf
Prebid.js/modules/koblerBidAdapter.js Line 134 in 180ddaf
Waardex Prebid.js/modules/waardexBidAdapter.js Line 99 in 412277f
pixfuture Prebid.js/modules/pixfutureBidAdapter.js Line 203 in e39cb75
Smilewanted
adRelevantis Prebid.js/modules/adrelevantisBidAdapter.js Line 431 in d4ad23f
SpotX Prebid.js/modules/spotxBidAdapter.js Line 183 in d4ad23f
Appnexus Prebid.js/modules/appnexusBidAdapter.js Line 730 in 412277f
The oneVideo module is an example of how to do this according to the new spec. |
@acsbendi https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/kobler.md indicates position is not the same as the ortb2 param. Would you consider renaming it? Some might find that confusing. Also, removing you from the list of adapters to fix. |
@patmmccann I've already opened a PR to remove that parameter completely :D prebid/prebid.github.io#3794 We originally used to differentiate between repeated placements (e.g. when the article is long and the same placement is used multiple times between paragraphs) but we stopped using it as it takes too much effort to maintain this information. |
how fortuitous, ty |
Conversant appears fixed here ; fyi @pycnvr Prebid.js/modules/conversantBidAdapter.js Line 80 in 2870089
|
Positiontype parameter is not documented in smilewanted adapter, we can't be sure what it means |
@patmmccann Thanks for tagging. It seems that adapters should be picking up values from mediaTypes.video.pos and mediaTypes.banner.pos. The line above in Conversant adapter only work for first party data. If that sounds right, I'll add it to our sprint. Thanks. |
Type of issue
Convention
Description
Similar to First Party Data and Video Parameters, many bidder accept page position as bidder-specific parameters. Publishers need to pass the same information to each bidder, but often with different values for each bidder.
Proposal
Prebid.js should adopt a convention for publishers to place 'position' in AdUnit.mediaType.banner.pos and AdUnit.mediaType.video.pos
The values are aligned with OpenRTB 2.5:
Requirements
Timeline
If approved, Prebid.org documentation and the Prebid Server bid adapter will be updated immediately. Bid Adapters will have until Prebid 5.0 (timeline TBD) to be able to read from mediaType.banner.pos and mediaType.video.pos and map values to their endpoint requirements.
The text was updated successfully, but these errors were encountered: