Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getSpec() for spotX has undefined gvlid #8165

Closed
grajzer opened this issue Mar 10, 2022 · 4 comments · Fixed by #8186
Closed

getSpec() for spotX has undefined gvlid #8165

grajzer opened this issue Mar 10, 2022 · 4 comments · Fixed by #8186
Assignees
Labels

Comments

@grajzer
Copy link
Contributor

grajzer commented Mar 10, 2022

Type of issue

Bug

Description

When gdprEnforcement is used, getSpec() is called for each adapter. Object returned for SpotX has undefined gvlid property, although it's defined in spotxBidAdapter.js (gvlid: 165).

Steps to reproduce

Downloaded prebid.js file and modified it by adding one console.log where that method is called.

screen

https://dejan.brid.tv/spotxgvlid/prebidpagetest.html

@patmmccann
Copy link
Collaborator

Also, what is this undocumented parameter

if (getBidIdParameter('spotx_all_google_consent', bid.params) == 1) {

@patmmccann
Copy link
Collaborator

Also, interestingly,

does not match the spotx doc, which has gvlid 52

@dgirardi
Copy link
Collaborator

@harpere can you take a look at this?

@robertrmartinez
Copy link
Collaborator

@patmmccann @dgirardi I will take this. Docs were updated to 52 which is the Rubicon / Magnite GVL ID. Will work with our team to fix and put the correct stuff in here asap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
5 participants