Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onBidWon sometimes runs on s2s bids #9515

Closed
dgirardi opened this issue Feb 7, 2023 · 1 comment
Closed

onBidWon sometimes runs on s2s bids #9515

dgirardi opened this issue Feb 7, 2023 · 1 comment

Comments

@dgirardi
Copy link
Collaborator

dgirardi commented Feb 7, 2023

Type of issue

Bug / Improvement

Description

An adapter's onBidWon handler will run on s2s bids if it's included in the bundle, but obviously not if it isn't. Besides the difference in behavior in itself, it's likely that not all adapters can actually accept an s2s bid in their onBidWon handler: they may expect it to be one that they generated. For example:

onBidWon: function(data) {
data.winNotification.forEach(function(unitWon) {
let adPartnerBidWonUrl = buildUrl({
protocol: ENDPOINT_PROTOCOL,
hostname: ENDPOINT_DOMAIN,
pathname: unitWon.path
});
if (unitWon.method === 'POST') {
spec.postRequest(adPartnerBidWonUrl, JSON.stringify(unitWon.data));
}
});
return true;
},

Proposal

The new onBidBillable method to be introduced for #4494 will be invoked only for client side bids.
Starting from version 8, onBidWon will also be invoked only for client-side bids.

@patmmccann
Copy link
Collaborator

#8539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants