From 6d434d6133fd4e233311a82db44bd2eac7c8d955 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Fri, 4 Jun 2021 11:15:54 -0400 Subject: [PATCH 1/5] bugfix --- modules/zetaBidAdapter.js | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index ee5c854df97..7a8c77359a4 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -87,6 +87,7 @@ export const spec = { badv: params.badv, bapp: params.bapp, source: params.source ? params.source : {}, + regs: params.regs ? params.regs : {}, ext: params.ext ? params.ext : {} }; @@ -99,17 +100,15 @@ export const spec = { payload.test = params.test; } if (request.gdprConsent) { - payload.regs = { - ext: { - gdpr: request.gdprConsent.gdprApplies === true ? 1 : 0 - } + payload.regs.ext = { + ...payload.regs.ext, + gdpr: request.gdprConsent.gdprApplies === true ? 1 : 0 }; } if (request.gdprConsent && request.gdprConsent.gdprApplies) { - payload.user = { - ext: { - consent: request.gdprConsent.consentString - } + payload.user.ext = { + ...payload.user.ext, + consent: request.gdprConsent.consentString }; } const postUrl = params.definerId !== '0' ? ENDPOINT_URL.concat('/', params.definerId) : ENDPOINT_URL; From 00f6caa75129461df417b771cef08a61ec9e9e8a Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Fri, 4 Jun 2021 11:20:02 -0400 Subject: [PATCH 2/5] update Prebid definer id --- modules/zetaBidAdapter.js | 2 +- modules/zetaBidAdapter.md | 2 +- test/spec/modules/zetaBidAdapter_spec.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index 7a8c77359a4..9318b18b99a 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -3,7 +3,7 @@ import { registerBidder } from '../src/adapters/bidderFactory.js'; import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; -const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=42770&in=1'; +const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=44253&in=1'; const DEFAULT_CUR = 'USD'; const TTL = 200; const NET_REV = true; diff --git a/modules/zetaBidAdapter.md b/modules/zetaBidAdapter.md index 89a9767d29a..e0f7271a4f1 100644 --- a/modules/zetaBidAdapter.md +++ b/modules/zetaBidAdapter.md @@ -35,7 +35,7 @@ Module that connects to Zeta's demand sources country: 'USA' } }, - definerId: '0', + definerId: '44253', test: 1 } } diff --git a/test/spec/modules/zetaBidAdapter_spec.js b/test/spec/modules/zetaBidAdapter_spec.js index ccdd5f43cb0..25350725dee 100644 --- a/test/spec/modules/zetaBidAdapter_spec.js +++ b/test/spec/modules/zetaBidAdapter_spec.js @@ -24,7 +24,7 @@ describe('Zeta Bid Adapter', function() { country: 'USA' } }, - definerId: '0', + definerId: '44253', test: 1 } }]; From b95f326a03e6f92fbda066ec2b179ed81d66f357 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Fri, 4 Jun 2021 15:00:43 -0400 Subject: [PATCH 3/5] use compatible syntax --- modules/zetaBidAdapter.js | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index 9318b18b99a..b12513821ee 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -4,6 +4,7 @@ import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=44253&in=1'; +const PREBID_DEFINER_ID = '44253' const DEFAULT_CUR = 'USD'; const TTL = 200; const NET_REV = true; @@ -92,6 +93,7 @@ export const spec = { }; payload.device.ua = navigator.userAgent; + payload.device.ip = navigator.ip; payload.site.page = bidderRequest.refererInfo.referer; payload.site.mobile = /(ios|ipod|ipad|iphone|android)/i.test(navigator.userAgent) ? 1 : 0; payload.ext.definerId = params.definerId; @@ -100,18 +102,18 @@ export const spec = { payload.test = params.test; } if (request.gdprConsent) { - payload.regs.ext = { - ...payload.regs.ext, - gdpr: request.gdprConsent.gdprApplies === true ? 1 : 0 - }; + payload.regs.ext = Object.assign( + payload.regs.ext, + {gdpr: request.gdprConsent.gdprApplies === true ? 1 : 0} + ); } if (request.gdprConsent && request.gdprConsent.gdprApplies) { - payload.user.ext = { - ...payload.user.ext, - consent: request.gdprConsent.consentString - }; + payload.user.ext = Object.assign( + payload.user.ext, + {consent: request.gdprConsent.consentString} + ); } - const postUrl = params.definerId !== '0' ? ENDPOINT_URL.concat('/', params.definerId) : ENDPOINT_URL; + const postUrl = params.definerId !== PREBID_DEFINER_ID ? ENDPOINT_URL.concat('/', params.definerId) : ENDPOINT_URL; return { method: 'POST', url: postUrl, From 4ec1f53b4f00f92dc6148d811fff6a38461b4ad0 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Fri, 4 Jun 2021 15:08:21 -0400 Subject: [PATCH 4/5] polishing --- modules/zetaBidAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index b12513821ee..726e13d8f8a 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -2,9 +2,9 @@ import * as utils from '../src/utils.js'; import { registerBidder } from '../src/adapters/bidderFactory.js'; import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; -const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; -const USER_SYNC_URL = 'https://p.rfihub.com/cm?pub=44253&in=1'; const PREBID_DEFINER_ID = '44253' +const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; +const USER_SYNC_URL = 'https://p.rfihub.com/cm?in=1&pub=' + PREBID_DEFINER_ID; const DEFAULT_CUR = 'USD'; const TTL = 200; const NET_REV = true; From a103ac8868847404b58810d7fa47cb4ee68c14c2 Mon Sep 17 00:00:00 2001 From: Myles Wehr Date: Fri, 4 Jun 2021 15:19:23 -0400 Subject: [PATCH 5/5] polishing --- modules/zetaBidAdapter.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/zetaBidAdapter.js b/modules/zetaBidAdapter.js index 726e13d8f8a..a6cbc831604 100644 --- a/modules/zetaBidAdapter.js +++ b/modules/zetaBidAdapter.js @@ -4,7 +4,7 @@ import {BANNER} from '../src/mediaTypes.js'; const BIDDER_CODE = 'zeta_global'; const PREBID_DEFINER_ID = '44253' const ENDPOINT_URL = 'https://prebid.rfihub.com/prebid'; -const USER_SYNC_URL = 'https://p.rfihub.com/cm?in=1&pub=' + PREBID_DEFINER_ID; +const USER_SYNC_URL = 'https://p.rfihub.com/cm?in=1&pub='; const DEFAULT_CUR = 'USD'; const TTL = 200; const NET_REV = true; @@ -163,7 +163,7 @@ export const spec = { if (syncOptions.iframeEnabled) { syncs.push({ type: 'iframe', - url: USER_SYNC_URL + url: USER_SYNC_URL.concat(PREBID_DEFINER_ID) }); } return syncs;