From 2184aa5a0a27b2094c433ad645450eb6e042dec7 Mon Sep 17 00:00:00 2001 From: Mehdi Bouallagui Date: Tue, 10 May 2022 18:07:32 +0200 Subject: [PATCH] removing floor field from bid request when not defined --- modules/oguryBidAdapter.js | 5 +++-- test/spec/modules/oguryBidAdapter_spec.js | 9 ++++----- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/modules/oguryBidAdapter.js b/modules/oguryBidAdapter.js index 7d2989b2066..295a0042f4b 100644 --- a/modules/oguryBidAdapter.js +++ b/modules/oguryBidAdapter.js @@ -10,7 +10,7 @@ const DEFAULT_TIMEOUT = 1000; const BID_HOST = 'https://mweb-hb.presage.io/api/header-bidding-request'; const TIMEOUT_MONITORING_HOST = 'https://ms-ads-monitoring-events.presage.io'; const MS_COOKIE_SYNC_DOMAIN = 'https://ms-cookie-sync.presage.io'; -const ADAPTER_VERSION = '1.2.10'; +const ADAPTER_VERSION = '1.2.11'; function isBidRequestValid(bid) { const adUnitSizes = getAdUnitSizes(bid); @@ -74,11 +74,12 @@ function buildRequests(validBidRequests, bidderRequest) { if (bidRequest.mediaTypes && bidRequest.mediaTypes.hasOwnProperty('banner')) { openRtbBidRequestBanner.site.id = bidRequest.params.assetKey; + const floor = getFloor(bidRequest); openRtbBidRequestBanner.imp.push({ id: bidRequest.bidId, tagid: bidRequest.params.adUnitId, - bidfloor: getFloor(bidRequest), + ...(floor && {bidfloor: floor}), banner: { format: sizes }, diff --git a/test/spec/modules/oguryBidAdapter_spec.js b/test/spec/modules/oguryBidAdapter_spec.js index acf62bf5a7b..0d1a530044f 100644 --- a/test/spec/modules/oguryBidAdapter_spec.js +++ b/test/spec/modules/oguryBidAdapter_spec.js @@ -245,7 +245,6 @@ describe('OguryBidAdapter', function () { }, { id: bidRequests[1].bidId, tagid: bidRequests[1].params.adUnitId, - bidfloor: 0, banner: { format: [{ w: 600, @@ -271,7 +270,7 @@ describe('OguryBidAdapter', function () { }, ext: { prebidversion: '$prebid.version$', - adapterversion: '1.2.10' + adapterversion: '1.2.11' } }; @@ -401,7 +400,7 @@ describe('OguryBidAdapter', function () { it('should handle bidFloor when currency is not USD', () => { const expectedRequestWithUnsupportedFloorCurrency = utils.deepClone(expectedRequestObject) - expectedRequestWithUnsupportedFloorCurrency.imp[0].bidfloor = 0; + delete expectedRequestWithUnsupportedFloorCurrency.imp[0].bidfloor; let validBidRequests = utils.deepClone(bidRequests); validBidRequests[0] = { ...validBidRequests[0], @@ -482,7 +481,7 @@ describe('OguryBidAdapter', function () { advertiserDomains: openRtbBidResponse.body.seatbid[0].bid[0].adomain }, nurl: openRtbBidResponse.body.seatbid[0].bid[0].nurl, - adapterVersion: '1.2.10', + adapterVersion: '1.2.11', prebidVersion: '$prebid.version$' }, { requestId: openRtbBidResponse.body.seatbid[0].bid[1].impid, @@ -499,7 +498,7 @@ describe('OguryBidAdapter', function () { advertiserDomains: openRtbBidResponse.body.seatbid[0].bid[1].adomain }, nurl: openRtbBidResponse.body.seatbid[0].bid[1].nurl, - adapterVersion: '1.2.10', + adapterVersion: '1.2.11', prebidVersion: '$prebid.version$' }]