Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

400 when playing the auction endpoint following ReadMe #1335

Closed
StarWindMoonCloud opened this issue Jun 4, 2020 · 4 comments
Closed

400 when playing the auction endpoint following ReadMe #1335

StarWindMoonCloud opened this issue Jun 4, 2020 · 4 comments

Comments

@StarWindMoonCloud
Copy link

command and output:
curl --data '{"description":"This uses Appnexus to fetch the prebid sample ad, as seen on prebid.org.","requestPayload":{"id":"some-request-id","site":{"page":"prebid.org"},"imp":[{"id":"some-impression-id","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}]},"ext":{"appnexus":{"placementId":12883451}}}],"tmax":500}}' "http://localhost:8000/openrtb2/auction"
Invalid request: request missing required field: "id"

doc
https://github.com/prebid/prebid-server/blob/master/docs/endpoints/openrtb2/auction.md

@StarWindMoonCloud
Copy link
Author

figured out, it should be json node of requestPayload instead of the whole json here, which is confusing though
view-source:https://raw.githubusercontent.com/prebid/prebid-server/master/endpoints/openrtb2/sample-requests/valid-whole/exemplary/prebid-test-ad.json

@SyntaxNode
Copy link
Contributor

I agree this is confusing. The sample file being referenced is designed for integration tests and includes extra markup. I can see why it was originally linked to perhaps always stay current, but the samples don't change very often.

How about we just embed the sample request alongside the sample response? I can put out a PR for that tomorrow.

@SyntaxNode
Copy link
Contributor

FYI: I'm fully aware the docs can use improvement. We're in the midst of a major overhaul, but I expect it to be a while before it's ready to be published. In the meantime, I ask for your patience and that you continue asking clarifying questions as GitHub issues.

@StarWindMoonCloud
Copy link
Author

Thank you @SyntaxNode for the quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants