-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidder-defined TTL #1386
Comments
Here's a cut at a technical description:
Will that cover it? |
appears to be a duplicate of #237 |
Wait, this feature isn't implemented yet - my description was a more detailed feature proposal. |
Discussed by Prebid Server Committee. Support was added in PrebidJS in prebid/Prebid.js#5419 to look in the |
I believe you're saying is that prebid/Prebid.js#5419 was incorrect -- So in addition to the steps described in my comment above, we ought to go back and change PBJS to look for exp instead of ttl. |
@rpanchyk has pointed out that PBS-Java already looks for seatbid.bid.exp. PBS-Go does too, but adds a 60-second buffer and uses the lower of the request.imp.exp and response.seatbid.bid.exp exchange/auction.go
So I'd suggest two things here:
other than that, we're good here? Bid adapters can already set bidresponse.exp and it will be respected. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@bretg Did the change to Prebid.js resolve this thread? |
@Aigolkin1991 - we believe this is adequately resolved now, except perhaps in bid adapter developer documentation. Just set the |
I'm looking for way to set TTL inside our adapter for bid.adm (banner,video,native separate) - this is important for our demand source, which have TTL for win and imp events. Currently we are getting discrepancy between supply source and demand in number of impressions, this occurs when adm is being rendered after impression record on our demand side has been already timed out, in this case only supply partner counts impression
The text was updated successfully, but these errors were encountered: