Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Digitrust Support #1464

Closed
SyntaxNode opened this issue Aug 27, 2020 · 3 comments
Closed

Remove Digitrust Support #1464

SyntaxNode opened this issue Aug 27, 2020 · 3 comments
Labels
Intent to implement An issue describing a plan for a major feature. These are intended for community feedback PBS-Java

Comments

@SyntaxNode
Copy link
Contributor

This issue is forked from an effort started by @patmmccann to begin removing Digitrust support since the IAB is no longer supporting it. The IAB issues a PR recently to remove support from PrebidJS: prebid/Prebid.js#5334

Proposal

  • Remove all explicit support for Digitrust from code, including all tests.
  • Remove the ext definition of Digitrust from the user.ext data structure.
  • Leave adapters which specifically look for Digitrust alone.

Open Questions

  • Some adapters are using the user.ext data structure to avoid code deduplication. Should we perhaps then leave the data structure alone and add a comment that's deprecated?
  • Should we still remove it when enforcing privacy policies (GDPR, CCPA, COPPA, ...)?

References In Code To Digitrust

  • endpoints/amp_auction_test.go : has additional tests that include digitrust.
  • endpoints/auction.go : validateUser() has some validation around digitrust.
  • endpoints/openrtb2/sample-requests/valid-whole/digitrust.json : exists should be renamed and edited if it is otherwise a useful test, or removed.
  • exchange/exchange_test.go : a couple of tests reference digitrust, we should perhaps remove the digitrust part of the sample requests.
  • exchange/utils_test.go : a couple of tests reference digitrust, we should perhaps remove the digitrust part of the sample requests.
  • exchange/utils.go : extractBuyerUIDs() is digitrust aware. We may want to excise that code.
  • exchange/exchangetest/request-other-user-ext.json : Modify or remove test?
  • exchange/exchangetest/request-user-no-prebid.json : Modify or remove test?
  • openrtb_ext/user.go : We have the digitrust spec defined in the user.ext definitions.
  • privacy/scrubber.go : We have code handling digitrust.
  • privacy/scrubber_test.go : We have tests covering digitrust.
@SyntaxNode SyntaxNode added the Intent to implement An issue describing a plan for a major feature. These are intended for community feedback label Sep 12, 2020
@bretg bretg added the PBS-Java label Oct 16, 2020
@SyntaxNode
Copy link
Contributor Author

Work is still needed for both PBS-Go and PBS-Java. The linked PR is not the complete solution for PBS-Go.

@SyntaxNode
Copy link
Contributor Author

Implemented in PBS-Go 0.166.0.

@bretg
Copy link
Contributor

bretg commented Jun 8, 2022

Done with PBS-Java 1.52

@bretg bretg closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Intent to implement An issue describing a plan for a major feature. These are intended for community feedback PBS-Java
Projects
None yet
Development

No branches or pull requests

2 participants