Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBS-core to suppress warning about $0 bids that aren't deals #1973

Closed
bretg opened this issue Aug 20, 2021 · 3 comments
Closed

PBS-core to suppress warning about $0 bids that aren't deals #1973

bretg opened this issue Aug 20, 2021 · 3 comments
Labels

Comments

@bretg
Copy link
Contributor

bretg commented Aug 20, 2021

Related to Issue #1937

Discussed in committee today. We agreed that the "Bid "%s" does not contain a positive (or zero if there is a deal) 'price'" warning should only be emitted to the client response in debug mode.

PBS-core should drop non-deal bids that are $0 or less during the bid validation step after emitting this warning to the client when in debug mode. In the metrics, this validation error should be lumped together with other types of invalid bid responses.

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@SyntaxNode SyntaxNode removed the stale label Jan 10, 2022
@bretg bretg removed the projectboard label Sep 8, 2022
@bretg bretg moved this from Triage to Ready for Dev in Prebid Server Prioritization Oct 21, 2022
@bretg bretg moved this from Ready for Dev to Needs Requirements in Prebid Server Prioritization Oct 21, 2022
@bretg bretg moved this from Needs Requirements to Ready for Dev in Prebid Server Prioritization Oct 21, 2022
@bretg
Copy link
Contributor Author

bretg commented Dec 19, 2022

released with PBS-Java 1.77

@SyntaxNode
Copy link
Contributor

Implemented in PBS-Go 2.6

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid Server Prioritization Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants