Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stored bid response not found #2487

Closed
VeronikaSolovei9 opened this issue Dec 7, 2022 · 4 comments
Closed

Stored bid response not found #2487

VeronikaSolovei9 opened this issue Dec 7, 2022 · 4 comments
Assignees
Labels

Comments

@VeronikaSolovei9
Copy link
Contributor

What is a correct way to handle impression with stored bid response if stored bid response is not found?
Currently we don't fail request if stored bid response is not found for one or more imps. Those impressions will have no bids back.
Question: should we run impression with stored bid response as usual impression if stored bid response is not found?

Follow up for proposed changes in this PR: #2473

@bretg
Copy link
Contributor

bretg commented Dec 8, 2022

Hi @VeronikaSolovei9 -- PBS-Java bails on the request with an error. I would suggest the same for PBS-Go

Invalid request format: Failed to fetch stored auction response for impId = a and storedAuctionResponse id = 1001-1.

@VeronikaSolovei9
Copy link
Contributor Author

Thank you for the answer Bret! If so then we will need to change current behavior and fail the request.

@VeronikaSolovei9
Copy link
Contributor Author

Please do not close this issue until this is fixed.

@SyntaxNode
Copy link
Contributor

Implemented in PBS-Go 0.251.0.

@github-project-automation github-project-automation bot moved this from Ready for Dev to Done in Prebid Server Prioritization Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

3 participants