-
Notifications
You must be signed in to change notification settings - Fork 764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSA initialization #3424
Comments
Edge CaseTo keep this logic simple, an empty dsa object counts as "exists". In the following case
|
Whatever's easier/more consistent with similar edge cases. I don't have a lot of sympathy for a request that comes in with an empty DSA object. I think |
It's easier to define "exists" as "not null", such that an empty object |
Gentlemen, IAB updated the spec and changed the names of 2 fields:
|
Support for this was released as part of https://github.com/prebid/prebid-server-java/releases/tag/2.10.0 |
I assume copying the default into the bid should happen before validation which means a bid with the defaults could still be discarded if DSA validation fails. |
correct |
@bretg If a host specifies a default DSA object and it is missing one of the integer fields ( If we set them to defaults, the validation logic is ok as is. If we omit, what is the validation behavior? If This is also relevant to a DSA specified on the incoming request. We previously said we don't care about the contents, we will just pass it through, but given that we have expanded the validation rules beyond just |
omit. No one really knows how this is going to work in the real world, so no defaults are feasible for now.
Easy - if the field that triggers the validation isn't specified, skip the validation. This is perfectly reasonable and under control of the publisher. Will update the other issue. |
FWIW, the initial issue said "If the request didn't contain regs.ext.dsa.dsarequired doesn't exist, then no response validation is done. Updated #3438 |
Publishers are generally responsible for creating the DSA object in the Prebid.js, but in some use cases, they can't, including App and AMP. And some Publishers might find it difficult to update their Prebid.js configuration across a broad network of sites in a short period.
Prebid Server host companies can help resolve this with stored request updates, but making a broad update across potentially thousands of DB entries in a short period might be difficult or undesirable.
So we propose a couple of new DSA account config flags:
regs.ext.dsa
exists and is not null, use it. We're done.privacy.dsa.default
exists and is not null:regs.ext.dsa
. Done.internal_gdpr
flag, and if true, copy the default value intoregs.ext.dsa
. Done.Note that the
internal_gdpr
flag is defined in the first flow chart of https://docs.google.com/document/d/1g0zAYc_EfqyilKD8N2qQ47uz0hdahY-t8vfb-vxZL5w/edit#heading=h.yjh8s4sv17vv . In short, it's true (1) when GDPR is enabled for the account and any of these are true:The text was updated successfully, but these errors were encountered: