Adview: adapter currency fix. #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.json format tidy up.
mansinahar
reviewed
Oct 26, 2021
(2)add test codes for currency.
mansinahar
reviewed
Nov 1, 2021
(2)test script re-fix.
|
Needs #2071 to be merged in before we can merge this one in |
AlexBVolcy
previously approved these changes
Nov 16, 2021
guscarreon
reviewed
Nov 18, 2021
There was a problem hiding this comment.
Looks good to me @AdviewOpen. Just one more ask: Now that pull request #2071 has been merged, can you please re-incorporate the JSON currency conversion test case you got rid of in a previous commit? JSON tests with currency conversion are now supported. As shown below, file adapters/adview/adviewtest/supplemental/currency_rate_not_found.json covers the error scenario in line 67.
Can we also add a JSON currency test to cover lines 71 and 72?
|
Roger , and test script has been already in git, great thx for all of you. |
guscarreon
approved these changes
Nov 19, 2021
There was a problem hiding this comment.
LGTM. @AdviewOpen we appreciate your response to our feedback
AlexBVolcy
approved these changes
Nov 23, 2021
wwwyyy
pushed a commit
to wwwyyy/prebid-server
that referenced
this pull request
Dec 20, 2021
* 'master' of https://github.com/wwwyyy/prebid-server: (23 commits) Add GPID Reserved Bidder Name (prebid#2107) Marsmedia adapter - param zoneId can get string and int (prebid#2105) Algorix: add Server Region Support (prebid#2096) New Adapter: Bizzclick (prebid#2056) Collect Prometheus Go process metrics (prebid#2101) Added channel support (prebid#2037) Rubicon: update fpd fields resolving (prebid#2091) Beachfront - Currency conversion (prebid#2078) New Adapter: Groupm (Alias Of PubMatic) (prebid#2042) Adform adapter lacked gross/net parameter support (prebid#2084) add iframe sync for openx (prebid#2094) changes to the correct user sync url (prebid#2092) Smaato: Add instl to tests (prebid#2089) Correct MakeRequests() output assertion in adapter JSON tests (prebid#2087) Adview: adapter currency fix. (prebid#2060) New Adapter: Coinzilla (prebid#2074) Syncer Level ExternalURL Override (prebid#2072) 33Across: Enable Support for SRA requests (prebid#2079) Currency conversion on adapter JSON tests (prebid#2071) New Adapter: VideoByte (prebid#2058) ...
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
Co-authored-by: wildcat0601 <[email protected]>
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Co-authored-by: wildcat0601 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the suggestion, fixed the response currency setting.