Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why aren't multiple scoped attributes allowed. #123

Open
DarioAmiri opened this issue May 16, 2017 · 6 comments
Open

Why aren't multiple scoped attributes allowed. #123

DarioAmiri opened this issue May 16, 2017 · 6 comments

Comments

@DarioAmiri
Copy link
Contributor

I just noticed that multiple scoped attributes are not allowed. It seems like this feature existed at some point and then was disabled by this commit:
ab94c98

Could somebody please explain why this constraint was added?

@DarioAmiri
Copy link
Contributor Author

@sanjeevchopra Please read my initial comment in this issue. In addition to not allowing multiple scopes per parent, it's also impossible to specify multiple parent entries with different scopes because the equal method of the Parent object disregards the "scopes" field entirely.

The current state of things makes it impossible to construct permission graphs where a user might inherit attributes from a role in more than one scopes. I.e. [email protected] is a an analyst when accessing resources in site 1 AND site 2.

@sanjeevchopra
Copy link
Contributor

Dario,
If I recall correctly, multiple scopes was disabled only until tests can be added to validate that use case. Currently, there are no tests for this use case.

@DarioAmiri
Copy link
Contributor Author

@sanjeevchopra I've tested some changes and will likely submit a pull request for this. What do I have to sign to contribute? What's the status with the induction into the Eclipse foundation?

@sanjeevchopra
Copy link
Contributor

@DarioAmiri The move to Eclipse Foundation is delayed due to other priorities for the ACS team. There is no defined contribution model, yet. @anurag-gujral , can you clarify requirements for contributions ?

@anurag-gujral
Copy link
Contributor

Dario ,
Sorry for the late reply. Can you please send out a pull request , we will review it and then we will bring your change in.Sorry this is only think I can think of until we move to eclipse foundation.
Please let me know if you have better ideas.
Thanks,
A

@johnpeterdev
Copy link

Is there any estimated date for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants