Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug with NERDTreeCascadeOpenSingleChildDir #547

Closed
mmaxs opened this issue Feb 6, 2016 · 10 comments
Closed

A bug with NERDTreeCascadeOpenSingleChildDir #547

mmaxs opened this issue Feb 6, 2016 · 10 comments
Labels
bug

Comments

@mmaxs
Copy link

mmaxs commented Feb 6, 2016

Steps to reproduce:

  • create the folder 'A' in some directory
  • create the subfolder 'B' in the folder 'A'
  • create the file 'file.txt' in the folder 'B'
  • open 'file.txt' from the GUI file manager with Vim
  • in Vim open NERDTree, you should see '/some directory/A/B/' as a tree root
  • select '.. (up dir)'
  • then select '.. (up dir)' one more time
  • now try to open the 'A/B/' node in NERDTree

It appears that the node cannot be open again from now.
@juanibiapina
Copy link
Contributor

Very annoying. I'm trying to disable cascade altogether, but it seems there is no way.

@mmaxs
Copy link
Author

mmaxs commented Mar 9, 2016

Now it is needed to press 'C' - (change tree root to the selected dir) + Enter to be able opening such a directory.

@bcoady
Copy link

bcoady commented Apr 28, 2016

I am having the same issue. I went back to NerdTree 4.2 for now which works fine.

@ZiYang-oyxy
Copy link

Click "x" key map(close parent of node) on the line of 'file.txt' will also reproduce this bug @scrooloose .

@ZiYang-oyxy
Copy link

Add a gif
tty

@PhilRunninger
Copy link
Member

@juanibiapina , does your PR #558 solve this issue?

@juanibiapina
Copy link
Contributor

It doesn't sove the issue at all. It only adds the option to deactivate the feature that has the bug.

@qifei9
Copy link

qifei9 commented Feb 20, 2017

I have the same issue.

@lifecrisis lifecrisis mentioned this issue Jun 29, 2017
Closed
@lifecrisis
Copy link
Contributor

This is a confirmed bug. The same as in issue #526. A fix is in progress.

@lifecrisis lifecrisis added the bug label Jun 30, 2017
lifecrisis pushed a commit to lifecrisis/nerdtree that referenced this issue Jul 2, 2017
Fix the "TreeDirNode.open()" method
ea7e4f3 
Issues preservim#547 and preservim#526 reported a problem with the "open()" method in
the "TreeDirNode" class.

Specifically, opening a cascade in the NERDTree will perform the
opening operation on the tail of the cascade. This is a problem when
other operations (such as the "u" mapping) close intermediate
cascaded directories, which causes opening the tail to have no
effect (other than toggling the arrow).

Here, the "open()" method was modified to open all directories in a
cascade whenever the tail is opened. This is the only reasonable fix
for this type of problem.

Fixes preservim#547 and fixes preservim#526.
@lifecrisis
Copy link
Contributor

ANNOUNCEMENT: Everyone experiencing this bug can try the fix in pull request #720. It should repair this problem without any side effects. The code is currently under review.

@PhilRunninger PhilRunninger mentioned this issue Oct 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@juanibiapina @qifei9 @ZiYang-oyxy @PhilRunninger @mmaxs @bcoady @lifecrisis