Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease startup-time by avoiding linear-time iteration over key mappings #851

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Decrease startup-time by avoiding linear-time iteration over key mappings #851

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6d757f
Decrease startup-time by avoiding iteration over maps
mnussbaum Jun 11, 2018
657be6b
Mark private function with leading underscore
mnussbaum Jun 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 16 additions & 22 deletions lib/nerdtree/key_map.vim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,23 @@
let s:KeyMap = {}
let g:NERDTreeKeyMap = s:KeyMap

"FUNCTION: KeyMap.All() {{{1
function! s:KeyMap.All()

if !exists('s:keyMaps')
let s:keyMaps = []
"FUNCTION: KeyMap.all() {{{1
function! s:KeyMap.all()
if !exists("s:keyMaps")
let s:keyMaps = {}
endif

call sort(s:keyMaps, s:KeyMap.Compare, s:KeyMap)

return s:keyMaps
endfunction

"FUNCTION: KeyMap.All() {{{1
function! s:KeyMap.All()
let sortedKeyMaps = values(s:KeyMap.all())
call sort(sortedKeyMaps, s:KeyMap.Compare, s:KeyMap)

return sortedKeyMaps
endfunction

"FUNCTION: KeyMap.Compare(keyMap1, keyMap2) {{{1
function! s:KeyMap.Compare(keyMap1, keyMap2)

Expand All @@ -31,17 +36,12 @@ endfunction

"FUNCTION: KeyMap.FindFor(key, scope) {{{1
function! s:KeyMap.FindFor(key, scope)
for i in s:KeyMap.All()
if i.key ==# a:key && i.scope ==# a:scope
return i
endif
endfor
return {}
return get(s:KeyMap.all(), a:key . a:scope, {})
endfunction

"FUNCTION: KeyMap.BindAll() {{{1
function! s:KeyMap.BindAll()
for i in s:KeyMap.All()
for i in values(s:KeyMap.all())
call i.bind()
endfor
endfunction
Expand All @@ -67,12 +67,7 @@ endfunction

"FUNCTION: KeyMap.Remove(key, scope) {{{1
function! s:KeyMap.Remove(key, scope)
let maps = s:KeyMap.All()
for i in range(len(maps))
if maps[i].key ==# a:key && maps[i].scope ==# a:scope
return remove(maps, i)
endif
endfor
return remove(s:keyMaps, a:key . a:scope)
endfunction

"FUNCTION: KeyMap.invoke() {{{1
Expand Down Expand Up @@ -170,8 +165,7 @@ endfunction

"FUNCTION: KeyMap.Add(keymap) {{{1
function! s:KeyMap.Add(keymap)
call s:KeyMap.Remove(a:keymap.key, a:keymap.scope)
call add(s:KeyMap.All(), a:keymap)
let s:keyMaps[a:keymap.key . a:keymap.scope] = a:keymap
endfunction

" vim: set sw=4 sts=4 et fdm=marker: