Default to placing cursor on root when closing bookmark table #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the cursor is not already positioned on a node when the bookmark table is closed, then the resulting position of the cursor is not determined. Here, we default to positioning the cursor on the root when the bookmark table is closed.
|
@lifecrisis , I checked on both Mac and Windows, and I don't see any difference between your branch's behavior and that of master's. What steps should I use to recreate the original issue? |
If the cursor was already on a tree node, we want it to remain on that tree node (which it does with this fix). However, if the cursor was somewhere above the tree, we now just put it on the tree root. |
PhilRunninger
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know why this bothered me so much... but it needed to be fixed.