Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <count>tabnext instead of <count>gt to allow users to remap gt. #877

Merged
merged 1 commit into from
Aug 25, 2018

Conversation

PhilRunninger
Copy link
Member

Fixes #762

NERDTree was using the <count>gt command to switch tabs. So, if the users had remapped gt, that would be used instead of the original functionality of gt. Fortunately, <count>tabnext does the same thing, so this simple fix replaces gt with tabnext.

Copy link
Contributor

@lifecrisis lifecrisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using :normal! instead of :normal in the first instance looks like it would have also fixed the problem. Be aware that :normal! is special in that it doesn't use any custom mappings that the user may have defined.

@lifecrisis
Copy link
Contributor

lifecrisis commented Aug 25, 2018

I think this is okay. I didn't review the functionality here because the code is definitely sound.

If you say it fixes the problem, I'm fine with it.

@lifecrisis lifecrisis merged commit b10c61b into master Aug 25, 2018
@lifecrisis lifecrisis deleted the replace_gt_with_tabnext branch August 25, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go key map works strange when gt is rebound
2 participants