You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add a sanity checker (com.facebook.presto.sql.planner.sanity) to LogicalPlanner to make sure all Expressions are translated to RowExpressions after optimization (TranslateExpressions). Starting code points:
Add sanity check to make sure FilterNode and ValuesNode have no Expression left. (More nodes to come based on the progress of PlanNode Expression-to-RowExpression Migration Plan #12546). There are many example sanity checkers in the codebase (com.facebook.presto.sql.planner.sanity). One can start from there.
Add the above sanity check to the right place in LogicalPlanner like where other checkers reside.
The text was updated successfully, but these errors were encountered:
highker
changed the title
Add sanity checker to check no expression left after optimization.
Add sanity checker to check no expression left after optimization
Apr 22, 2019
Add a sanity checker (
com.facebook.presto.sql.planner.sanity
) toLogicalPlanner
to make sure allExpression
s are translated toRowExpression
s after optimization (TranslateExpressions
). Starting code points:presto/presto-main/src/main/java/com/facebook/presto/sql/planner/LogicalPlanner.java
Line 187 in 9cedeb9
The task includes:
FilterNode
andValuesNode
have noExpression
left. (More nodes to come based on the progress of PlanNode Expression-to-RowExpression Migration Plan #12546). There are many example sanity checkers in the codebase (com.facebook.presto.sql.planner.sanity
). One can start from there.LogicalPlanner
like where other checkers reside.The text was updated successfully, but these errors were encountered: