Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Difference in detection in Linux / macOS #7963

Closed
moltar opened this issue Apr 6, 2020 · 2 comments
Closed

Difference in detection in Linux / macOS #7963

moltar opened this issue Apr 6, 2020 · 2 comments
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:question Questions and support requests. Please use Stack Overflow for them, not the issue tracker.

Comments

@moltar
Copy link

moltar commented Apr 6, 2020

Seems like there is a difference in carriage return handling between macOS and Windows.

Here is a GitHub action that is failing to run in Windows: https://github.com/ScaleLeap/semantic-release-config/runs/564240533?check_suite_focus=true#step:6:11

Exactly the same code passes under Linux: https://github.com/ScaleLeap/semantic-release-config/runs/564240546?check_suite_focus=true#step:6:1

I also tested on macOS locally and it also passes.

Prettier version: 2.0.4
@thorn0 thorn0 added status:awaiting response Issues that require answers to questions from maintainers before action can be taken type:question Questions and support requests. Please use Stack Overflow for them, not the issue tracker. labels Apr 6, 2020
@thorn0
Copy link
Member

thorn0 commented Apr 6, 2020

Please see the Prettier 2.0 blog post and the docs for the endOfLine option.

@moltar
Copy link
Author

moltar commented Apr 6, 2020

Thanks for the hints!

Seems to be related to #7825.

And actions/checkout#135

@moltar moltar closed this as completed Apr 6, 2020
@no-response no-response bot removed the status:awaiting response Issues that require answers to questions from maintainers before action can be taken label Apr 6, 2020
@github-actions github-actions bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jul 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. type:question Questions and support requests. Please use Stack Overflow for them, not the issue tracker.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thorn0 @moltar