Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running Prettier wipes out all existing marks #251

Open
gabesoft opened this issue Jul 5, 2020 · 5 comments
Open

Running Prettier wipes out all existing marks #251

gabesoft opened this issue Jul 5, 2020 · 5 comments

Comments

@gabesoft
Copy link

gabesoft commented Jul 5, 2020

Do you want to request a feature or report a bug?
Report a bug

What is the current/expected behavior?
After running Prettier all user created marks in the current buffer are deleted

What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-alpha

What version of prettier are you using - (output of :PrettierCliVersion) ?
2.0.5

What is your prettier executable path - (output of :PrettierCliPath) ?
Absolute path to the project's node_modules/.bin/prettier

Did this work in previous versions of vim-prettier and/or prettier ?
Haven't tested

So to reproduce:

  1. add a mark via ma
  2. run Prettier (ensure this resulted in some changes)
  3. trying to go to the mark via 'a does not work
@buschco
Copy link

buschco commented Jul 22, 2020

I experience the same but only in lines that are prettified. Unmodified lines will remain the marks.

@DanielPower
Copy link

I'm also experiencing this. If Prettier encounters an error, it will:

If using :Prettier, replace the buffer with the error. Discarding the contents of the file you were working on.

If using :PrettierAsync, empty the buffer. Discarding the contents of the file you were working on.

This makes the extension completely unusable in its current state.

@Artawower
Copy link

Same problem

@mitermayer
Copy link
Member

mitermayer commented Jun 3, 2021

Could you folks please do a plug update and check if this PR #300 fixed this issue for you?

@buschco
Copy link

buschco commented Jun 3, 2021

It seems to work fine now!
Very nice! Thank you so much 🙏 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants