Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trailing_comma = 'es5' setting not working #258

Closed
haruki-m opened this issue Aug 5, 2020 · 2 comments
Closed

trailing_comma = 'es5' setting not working #258

haruki-m opened this issue Aug 5, 2020 · 2 comments

Comments

@haruki-m
Copy link

haruki-m commented Aug 5, 2020

Do you want to request a feature or report a bug?
Report a bug

What is the current/expected behavior?
Current:
let g:prettier#config#trailing_comma = 'none' and let g:prettier#config#trailing_comma = 'all' works perfectly, butlet g:prettier#config#trailing_comma = 'es5' gives me an error message in vim: Prettier: failed to parse buffer

Expected:
Setting let g:prettier#config#trailing_comma = 'es5' shouldn't give me an error message and should work.

What version of vim-prettier are you using - (output of :PrettierVersion) ?
1.0.0-alpha

What version of prettier are you using - (output of :PrettierCliVersion) ?
1.19.1^@

What is your prettier executable path - (output of :PrettierCliPath) ?
/Users/[name]/.vim/plugged/vim-prettier/node_modules/.bin/prettier

Did this work in previous versions of vim-prettier and/or prettier ?
Not sure

@jasonkit
Copy link

jasonkit commented Aug 13, 2020

I have the same issue.
This should be related to prettier/plugin-php#964

A quick workaround is upgrade @prettier/plugin-php version to latest version.

You can do so by

cd /Users/[name]/.vim/plugged/vim-prettier
# modify package.json to use latest version of @prettier/plugin-php
yarn

@mitermayer
Copy link
Member

Did a new release and no longer can reproduce this issue, if you still having problems feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants