Event listener leak in ReorderableRow and ReorderableColumn

[woppa684]

I'm submitting a ... (check one with "x")

[x ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

ReorderableRow and ReorderableColumn have bindEvents and undbindEvents methods. The unbindEvents for ReorderableRow is never called and the one for ReorderanleColumn is called in its ngOnDestroy. Not calling the one for the row already seems like a bug to me, but the main problem is in the implementation of both the unbind methods. To illustrate this, a small excerpt from one of the bind functions:

primeng/src/app/components/table/table.ts

Lines 3315 to 3316 in 3fe4a80

	this.mouseDownListener = this.onMouseDown.bind(this);
	this.el.nativeElement.addEventListener('mousedown', this.mouseDownListener);

And the corresponding unbind:

primeng/src/app/components/table/table.ts

Lines 3333 to 3336 in 3fe4a80

	if (this.mouseDownListener) {
	document.removeEventListener('mousedown', this.mouseDownListener);
	this.mouseDownListener = null;
	}

As can be seen, the listeners are registered on the nativeElement but removed from the document (where the listener was never registered), leaving the event listeners on the nativeElement behind. One could argue that, as the element is removed also the listeners get cleaned up, but this does not work for every usecase. Also, it seems that the idea was to have unbind methods, so let's make sure that they're correct and used :)

As mentioned, ReorderableColumn does have an ngOnDestroy (see below) but ReorderableRow has not.

primeng/src/app/components/table/table.ts

Lines 3393 to 3395 in 3fe4a80

	ngOnDestroy() {
	this.unbindEvents();
	}

[woppa684]

@yigitfindikli
Ok, so this fix adds the ngOnDestroy for ReorderableRow, what about the wrong unbind implementation? :) I don't think this issue should have been closed already. I think we can agree that adding an event listener to one element and removing it from somewhere else does not work, right?

[woppa684]

@yigitfindikli I could also make a PR if you prefer, but it seems trivial to just replace the document references to this.el.nativeElement in the unbindEvents methods.