Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: aria-expanded is hard-coded to false #12590

Closed
dcbroad3 opened this issue Feb 1, 2023 · 1 comment
Closed

Dropdown: aria-expanded is hard-coded to false #12590

dcbroad3 opened this issue Feb 1, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@dcbroad3
Copy link
Contributor

dcbroad3 commented Feb 1, 2023

Describe the bug

The accessibility attribute aria-expanded should indicate whether a combobox is expanded or collapsed. PrimeNG's dropdown template currently has this attribute hard-coded as false, but it should use the value of the overlayVisible property instead.

Environment

any

Reproducer

No response

Angular version

15

PrimeNG version

15

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@dcbroad3 dcbroad3 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 1, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants