Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .warn severity class #15913

Closed
jorgebenaventee opened this issue Jun 27, 2024 · 2 comments · Fixed by #15928
Closed

Add .warn severity class #15913

jorgebenaventee opened this issue Jun 27, 2024 · 2 comments · Fixed by #15928
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jorgebenaventee
Copy link

Describe the bug

In version 17.15.0, buttons and messages severity options included "warn" to display them with a yellow background. As of 17.18.1 it is replaced by "warning" breaking compatibility with themes like Freya as it only supports "warn" as a class. As a workaround, you can use [severity]="$any('warn')" to render them correctly.

Environment

I am using Angular 17.3.8 with Node version v20.5.1 and PrimeNG version 17.18.1

Reproducer

No response

Angular version

17.3.8

PrimeNG version

17.18.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.5.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@jorgebenaventee jorgebenaventee added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 27, 2024
@jorgebenaventee jorgebenaventee changed the title Add .warn class Add .warn severity class Jun 27, 2024
@davidda
Copy link
Contributor

davidda commented Jul 1, 2024

This should be fixed asap. It is even wrong in PrimeNGs demo pages. The type requires "warning" but to make it work you must set "warn".

https://stackblitz.com/edit/yckkaz?file=src%2Fapp%2Fmessages-severity-demo.ts

@cetincakiroglu cetincakiroglu added this to the 17.18.3 milestone Jul 1, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 1, 2024
@cetincakiroglu
Copy link
Contributor

Hi @davidda @jorgebenaventee ,

Thanks for reporting the issue, probably it happens due to a typo. It should be warn not warning. We'll address this issue in 17.18.3 this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants