Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Format file size to accept locale in error message #16382

Closed
petrf22 opened this issue Sep 13, 2024 · 0 comments · Fixed by #16383
Closed

FileUpload: Format file size to accept locale in error message #16382

petrf22 opened this issue Sep 13, 2024 · 0 comments · Fixed by #16383
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.13

Comments

@petrf22
Copy link
Contributor

petrf22 commented Sep 13, 2024

Describe the bug

If you upload a file that is larger than the maximum allowed size, the FileUpload component will displays a message with a formatted number that does not accept the Angular locale.

Environment

Windows 11

Reproducer

No response

Angular version

18.2.2

PrimeNG version

17.18.3

Build / Runtime

Angular CLI App

Language

ALL

Node version (for AoT issues node --version)

20.15.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Formatted number that does not accept the Angular locale.
@petrf22 petrf22 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 13, 2024
@petrf22 petrf22 mentioned this issue Sep 13, 2024
Merged
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 18, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Nov 18, 2024
@mertsincan mertsincan linked a pull request Nov 18, 2024 that will close this issue
Accept the locale for the file size of the format #16383
Merged
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 6, 2024
@github-project-automation github-project-automation bot moved this to Done in PrimeNG Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
17.18.13
Development

Successfully merging a pull request may close this issue.

Accept the locale for the file size of the format petrf22/primeng
2 participants
@petrf22 @mertsincan