Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Table Virtual Scroll does not correctly work with Row Expansion #16438

Closed
jackiems82 opened this issue Sep 26, 2024 · 2 comments · Fixed by #16807
Closed

Component: Table Virtual Scroll does not correctly work with Row Expansion #16438

jackiems82 opened this issue Sep 26, 2024 · 2 comments · Fixed by #16807
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jackiems82
Copy link

jackiems82 commented Sep 26, 2024

Describe the bug

Combining Virtual Scroll with Row Expansion does not always seem to work.
When the content of the expanded area is quite high, you cannot scroll to the end of the table when there are only a few rows. When there are more rows (e.g. 100) You can correctly scroll to the end, but while scrolling down from the top you will encounter a point where the scroll jumps ahead a couple of rows more than it should. Probably due to swapping out the rows in the DOM.
I need to use lazy loading as there can be quite a number of rows to display. Also the expandable area can have a different height per row.

Here is a stackblitz that shows this: https://stackblitz.com/edit/stackblitz-starters-s7bkee

Environment

Windows 10

Reproducer

No response

Angular version

18.0.0

PrimeNG version

17.18.10

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.15.1

Browser(s)

No response

Steps to reproduce the behavior

First scenario:

  1. Expand the first row and scroll to the end with either mouse wheel or by dragging the scroller.
    => The scroll area jumps up everytime you reach the bottom.

Second scenario:

  1. In app.component.ts, line 25, change the array length from 10 to 100.
  2. Expand the first row and scroll down.
    => Around when row with id 11 comes into view, when scrolling further the view will jump several rows down (for me it where 5) when usually it only scrolls around 1 row when using the mouse wheel.

Expected behavior

I would expect that the scrolling always works without jumping back up or moving too fast ahead, possibly skipping rows that cannot be seen in this case.

@jackiems82 jackiems82 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 26, 2024
@cetincakiroglu cetincakiroglu modified the milestone: 18.0.0-beta.3 Oct 11, 2024
@cetincakiroglu cetincakiroglu added this to the 18.0.0-rc.1 milestone Oct 26, 2024
@mertsincan mertsincan removed this from the 18.0.0-rc.2 milestone Nov 19, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 19, 2024
@mertsincan mertsincan added this to the Future milestone Nov 19, 2024
Copy link

Thanks a lot for this issue! PrimeNG team's roadmap is busy, but community feedback is crucial in prioritization. The more upvotes help ensure this fix can be addressed quickly or the related PR can be merged soon.

Copy link

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Help Wanted Issue or pull request requires extra help and feedback Resolution: Needs Upvote 👍 Support this idea or feature by adding an upvote. Community feedback helps with prioritization. labels Nov 22, 2024
@mertsincan mertsincan modified the milestones: Future, 17.18.13 Nov 22, 2024
@mertsincan mertsincan moved this to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants